Add depends_on chain for secret scope ACLs to fix flaky permission removal
#4258
+115
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moval The secret scope permissions test fails ~33% of the time when using the Terraform bundle engine. The root cause is a backend API race condition where parallel ACL modifications return inconsistent results. The direct bundle engine already works around this by sequentializing ACL operations (see #3886): // Set ACLs. The service returns inconsistent results for parallel // API calls. That's why we do them sequentially here to maintain // correctness. The Terraform provider has a similar workaround for creates via robustPutACL with retry/verification (terraform-provider-databricks#4885, issue #4195), but deletions have no such protection. This change adds a depends_on chain between ACL resources, forcing Terraform to execute them sequentially: ACL_0 → depends_on: [scope] ACL_1 → depends_on: [scope, ACL_0] ACL_2 → depends_on: [scope, ACL_1] This avoids triggering the backend race condition without requiring changes to the Terraform provider. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Jan 12, 2026
Collaborator
|
Commit: e4e26cb
36 interesting tests: 13 KNOWN, 11 RECOVERED, 9 flaky, 2 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 48015af
32 interesting tests: 14 RECOVERED, 10 KNOWN, 4 flaky, 3 BUG, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change adds a depends_on chain between ACL resources, forcing Terraform to execute them sequentially:
Why
The secret scope permissions test fails ~33% of the time when using the Terraform deployment engine. The root cause is a backend API race condition where parallel ACL modifications return inconsistent results.
The direct bundle engine already works around this by sequentializing ACL operations (see #3886):
The Terraform provider has a similar workaround for creates via robustPutACL with retry/verification (databricks/terraform-provider-databricks#4885, issue databricks/terraform-provider-databricks#4195), but deletions have no such protection.
This avoids triggering the backend race condition without requiring changes to the Terraform provider.
Tests
Manually ran the failing test 10 times and confirmed it no longer fails.